Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: EDU Event Detail Page #527

Merged
merged 24 commits into from
Jul 31, 2024
Merged

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports https://github.com/nasa-jpl/www/issues/141

  • Adds PageEduEventDetail template component
  • Fixes CalendarButton component
  • Adds a "dark mode" for BlockLinkCard, which is used in the "Explore More" section at the bottom of the page
  • Card styles are not complete -- they are part of a separate issue: https://github.com/nasa-jpl/www/issues/191

Instructions to test

  1. make vue-storybook
  2. view http://localhost:6006/?path=/story/templates-edu-pageedueventdetail--base-story&globals=theme:ThemeEdu

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle
Copy link
Member Author

Noting that the Percy snapshots are nearly useless as some will fail and then succeed, making the diff unusable. Attempting to fix that here. If I can't, I'll create a new issue and work on it separately.

@stephiescastle
Copy link
Member Author

Did not solve the percy issue in this PR. I've opened an issue with the percy-storybook team: percy/percy-storybook#1008

@stephiescastle stephiescastle merged commit 475f3ed into main Jul 31, 2024
7 checks passed
@stephiescastle stephiescastle deleted the feature/141-edu-event-page branch July 31, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants